Discussion:
[PROPOSAL] Eliminate most of the proxy.node metrics
Leif Hedstrom
2018-05-03 20:53:04 UTC
Permalink
In an effort to clean things up, I’d like to remove a lot of the metrics that are calculated via metrics.config. There are three categories that I’m eliminating:

1) Those which are purely copying from the corresponding proxy.process metric.

2) The _avg_ and _10s metrics

3) The ratios metrics.


I feel that #1 is a slam dunk to remove, and #2 and #3 I feel pretty strongly belong in a monitoring software / tool, to better calculate changes and ratios.

I’ve prepared a PR with the changes:

https://github.com/apache/trafficserver/pull/3567


The full list of removed metrics are listed in a comment there.

Cheers,

— leif
Alan M. Carroll
2018-05-03 22:22:45 UTC
Permalink
+1. In our production these are all calculated in the data gathering system anyway, which gives a lot more flexibility (such as deciding on new computed metrics after the fact).
Post by Leif Hedstrom
1) Those which are purely copying from the corresponding proxy.process metric.
2) The _avg_ and _10s metrics
3) The ratios metrics.
I feel that #1 is a slam dunk to remove, and #2 and #3 I feel pretty strongly belong in a monitoring software / tool, to better calculate changes and ratios.
https://github.com/apache/trafficserver/pull/3567
The full list of removed metrics are listed in a comment there.
Cheers,
— leif
Patrick O'Brien
2018-05-03 22:39:22 UTC
Permalink
+1. Our production monitoring system ignores all of these metrics already.
In an effort to clean things up, I’d like to remove a lot of the metrics
that are calculated via metrics.config. There are three categories that I’m
1) Those which are purely copying from the corresponding proxy.process metric.
2) The _avg_ and _10s metrics
3) The ratios metrics.
I feel that #1 is a slam dunk to remove, and #2 and #3 I feel pretty
strongly belong in a monitoring software / tool, to better calculate
changes and ratios.
https://github.com/apache/trafficserver/pull/3567
The full list of removed metrics are listed in a comment there.
Cheers,
— leif
Bryan Call
2018-05-03 22:43:43 UTC
Permalink
+1 - All of these are calculated and stat tracking tools can do it themselves

-Bryan
Post by Leif Hedstrom
1) Those which are purely copying from the corresponding proxy.process metric.
2) The _avg_ and _10s metrics
3) The ratios metrics.
I feel that #1 is a slam dunk to remove, and #2 and #3 I feel pretty strongly belong in a monitoring software / tool, to better calculate changes and ratios.
https://github.com/apache/trafficserver/pull/3567
The full list of removed metrics are listed in a comment there.
Cheers,
— leif
Steven R. Feltner
2018-05-04 11:13:40 UTC
Permalink
+1 - Agree that other external tools are better suited for collecting and calculating these metrics.

Thanks,
Steven

On 5/3/18, 4:53 PM, "Leif Hedstrom" <***@apache.org> wrote:

In an effort to clean things up, I’d like to remove a lot of the metrics that are calculated via metrics.config. There are three categories that I’m eliminating:

1) Those which are purely copying from the corresponding proxy.process metric.

2) The _avg_ and _10s metrics

3) The ratios metrics.


I feel that #1 is a slam dunk to remove, and #2 and #3 I feel pretty strongly belong in a monitoring software / tool, to better calculate changes and ratios.

I’ve prepared a PR with the changes:

https://github.com/apache/trafficserver/pull/3567


The full list of removed metrics are listed in a comment there.

Cheers,
Leif Hedstrom
2018-05-07 10:08:24 UTC
Permalink
Post by Steven R. Feltner
+1 - Agree that other external tools are better suited for collecting and calculating these metrics.
Alright, calling this, and will land my PR once amc approves it.

— leif

Loading...